Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom protocols like mailto: in ZIM articles are blocked in Chromium browsers #615

Closed
Jaifroid opened this issue Jun 4, 2024 · 1 comment · Fixed by #616
Closed

Custom protocols like mailto: in ZIM articles are blocked in Chromium browsers #615

Jaifroid opened this issue Jun 4, 2024 · 1 comment · Fixed by #616
Assignees
@Jaifroid
Labels
bug/non-critical upstream Should be worked on in kiwix-js
Milestone
Release 3.4.0

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Jun 4, 2024

As stated in kiwix/libkiwix#1090, the solution is to add mailto: as an exception for default-src (or frame-src if it exists) in the CSP.
@Jaifroid Jaifroid added upstream Should be worked on in kiwix-js bug/non-critical labels Jun 4, 2024
@Jaifroid Jaifroid added this to the Release 3.4.0 milestone Jun 4, 2024
@Jaifroid Jaifroid self-assigned this Jun 4, 2024
@Jaifroid Jaifroid mentioned this issue Jun 4, 2024
Merged
@Jaifroid Jaifroid changed the title mailto: links in ZIM articles are blocked in Chromium browsers Custom protocols like mailto: in ZIM articles are blocked in Chromium browsers Jun 6, 2024
@Jaifroid
Copy link
Member Author

Jaifroid commented Jun 6, 2024

Changed title because we shouldn't limit this to mailto: considering we can have things like skype:, zoomus:, and an infinity of custom URI schemata. So they need to be handled generically.

Jaifroid added a commit that referenced this issue Jun 15, 2024
@Jaifroid
Handle custom protocols and URI schemata to avoid CSP violations #615 (…
2b3a8c3 
…#616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
bug/non-critical upstream Should be worked on in kiwix-js
Projects
None yet
Milestone
Release 3.4.0
Development

Successfully merging a pull request may close this issue.

Handle custom protocols and URI schemata to avoid CSP violations kiwix/kiwix-js-pwa
1 participant
@Jaifroid