Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title description from popovers #657

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

Jaifroid
Copy link
Member

@Jaifroid Jaifroid commented Oct 6, 2024

This affects at least Wikivoyage ZIMs produced from the mobile HTML endpoint. PR simply applies id-based exclusion filter when constructing the popover content.

@Jaifroid Jaifroid added upstream Should be worked on in kiwix-js bug/non-critical user interface UI issues labels Oct 6, 2024
@Jaifroid Jaifroid added this to the Release 3.5.0 milestone Oct 6, 2024
@Jaifroid Jaifroid self-assigned this Oct 6, 2024
@Jaifroid
Copy link
Member Author

Jaifroid commented Oct 6, 2024

Tested and working on Firefox, Edge, and Edge 18 via BrowserStack. Also tested that it compiles and runs on IE11.

@Jaifroid Jaifroid merged commit 00f911c into main Oct 6, 2024
1 check passed
@Jaifroid Jaifroid deleted the Remove-title-description-from-popovers branch October 6, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/non-critical upstream Should be worked on in kiwix-js user interface UI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant