Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap to later version #705

Open
Jaifroid opened this issue Feb 21, 2021 · 6 comments
Open

Upgrade Bootstrap to later version #705

Jaifroid opened this issue Feb 21, 2021 · 6 comments
Assignees
Milestone

Comments

@Jaifroid
Copy link
Member

Bootstrap 5 is now available (albeit in beta, but it is the currently recommended version). A significant advantage IMHO is that it now uses an open-source SVG-based icon library (which can be themed with CSS), and since we are looking to move towards a more icon-driven UI, we should consider this. I haven't yet checked out what is deprecated.

@Jaifroid Jaifroid added this to the v3.2 milestone Feb 21, 2021
@Jaifroid Jaifroid self-assigned this Feb 21, 2021
@Jaifroid
Copy link
Member Author

Bootstrap 5 does not officially support IE11 or Edge <79, or Firefox <60. However, accoding to this repo, support for it can be added back for IE11 with some polyfills:

https://coliff.github.io/bootstrap-ie11/

IE11 is not EOL for another three years (surprisingly). We would need to be sure those polyfills also support the other browsers or webviews we currently support: Edge Legacy (although it is EOL in a couple of months, it lives on for now in the webviews for UWP apps), and the Firefox used in Firefox OS.

@Bam92
Copy link

Bam92 commented May 11, 2021

Hi!

I'm wondering if this issue is going on well or does it need a help.

@Jaifroid
Copy link
Member Author

@Bam92 This one is a bit complex, unless you have experience with Bootstrap. In particular, the lack of support for IE11 would complicate this upgrade (as in my previous comment). I suggest you work on #710 first, as it would get you familiar with the codebase.

@kelson42
Copy link
Collaborator

IE11 being now deprecated (see readme), what stopps us to move quickly on this?

@Jaifroid
Copy link
Member Author

IE11 being now deprecated (see readme), what stops us to move quickly on this?

Two things:

  • Deprecated doesn't mean we would consciously take steps that we know would prevent the app being used on a platform/browser. In this case, it would affect a wide range of browsers: Firefox < 60, Edge < 79 (hence the UWP app would stop working), as well as IE11. There is the possibility of using certain polyfills that might make it work on these platforms, but it needs investigation.
  • Lack of time and person-power...

@Jaifroid Jaifroid changed the title Upgrade Bootstrap to version 5.0.0 Upgrade Bootstrap to later version Mar 4, 2023
@Jaifroid
Copy link
Member Author

Jaifroid commented Mar 4, 2023

I notice Bootstrap is now on Version 10! We are on Version 4 here. However, support for old browsers may well be a blocker in later versions, and our UI is quite simple, so upgrading may not bring any tangible benefit other than removing dependency on jQuery (see #921).

@Jaifroid Jaifroid modified the milestones: v3.9, v4.0 Apr 22, 2023
@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants