Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove as much jQuery as possible from Bootstrap modal invocations #921

Closed
Jaifroid opened this issue Nov 14, 2022 · 8 comments · Fixed by #968
Closed

Remove as much jQuery as possible from Bootstrap modal invocations #921

Jaifroid opened this issue Nov 14, 2022 · 8 comments · Fixed by #968
Assignees
@aritroCoder
Labels
cleanup good first issue remove-jquery Issues or PRs involving removal of jQuery
Milestone
v3.8

Comments

@Jaifroid
Copy link
Member

Sub-issue of #367. Some, possibly most, use of jQuery to invoke and close Bootstrap modals can be substituted with native JS, but the underlying Bootstrap code depends on jQuery, so some methods will have to remain until #705 (which removes jQuery from Bootstrap).
@Jaifroid Jaifroid added cleanup remove-jquery Issues or PRs involving removal of jQuery labels Nov 14, 2022
@Jaifroid Jaifroid added this to the v3.8 milestone Nov 14, 2022
@Jaifroid Jaifroid mentioned this issue Nov 14, 2022
Closed
@Abhishek-1337
Copy link

Hey,
I am new to open source and I am thinking of contributing to this issue. Should I go on with this one?

@Jaifroid
Copy link
Member Author

@Abhishek-1337 If you're new to JS development, then you might find #918 to be easier. I've unassigned the person who was going to do that, as there's been no movement for 2-3 months.

@Abhishek-1337
Copy link

@Jaifroid #918 looks fine to me. Working on it, Is there any info/advice that I should know about?

@aritroCoder
Copy link
Contributor

Can I work in this issue?

@Jaifroid
Copy link
Member Author

@aritroCoder Yes, that's fine. I'm assigning you.

@aritroCoder aritroCoder mentioned this issue Feb 28, 2023
Merged
@aritroCoder
Copy link
Contributor

@Jaifroid have a look at the PR

@satyampsoni
Copy link

can i work on this?

@Jaifroid
Copy link
Member Author

Jaifroid commented Mar 4, 2023

@satyampsoni There is already a PR in progress! Please choose another issue.

@Jaifroid Jaifroid mentioned this issue Mar 4, 2023
Open
Jaifroid pushed a commit that referenced this issue Mar 26, 2023
@aritroCoder
Removed usage of jquery while opening and closing bootstrap modals #921…
0b2211c 
… (#968)

Signed off by @aritroCoder.
@Jaifroid Jaifroid modified the milestones: v3.9, v3.8 Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aritroCoder aritroCoder

Labels
cleanup good first issue remove-jquery Issues or PRs involving removal of jQuery
Projects
None yet
Milestone
v3.8
Development

Successfully merging a pull request may close this issue.

Removed usage of jquery while opening and closing bootstrap modals aritroCoder/kiwix-js
4 participants
@Jaifroid @Abhishek-1337 @aritroCoder @satyampsoni