Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert jQuery .on event listeners to their native JS equivalents #918

Closed
Jaifroid opened this issue Nov 14, 2022 · 6 comments · Fixed by #1035
Closed

Convert jQuery .on event listeners to their native JS equivalents #918

Jaifroid opened this issue Nov 14, 2022 · 6 comments · Fixed by #1035
Assignees
Labels
cleanup remove-jquery Issues or PRs involving removal of jQuery
Milestone

Comments

@Jaifroid
Copy link
Member

This is a sub-issue of #367.

@dheerajdlalwani
Copy link
Contributor

Shall I take up this one too? Seems like the logical next step after closing #927.

@Abhishek-1337
Copy link

This seems beginner friendly. Works for me. Can you help me to start?

@Jaifroid
Copy link
Member Author

@Abhishek-1337 Thank you for offering to work on this issue. Please read carefully the whole of the CONTRIBUTING document. The only thing that's out of date there is the mention of removing -WIP to test the Chromium extension (I'm not using -WIP label any more). When you've set up and can access/edit the app's code (you should make a dedicated branch on your clone to work on it), let me know, and I can guide you with regard to the specifics of this issue.

@Abhishek-1337
Copy link

Abhishek-1337 commented Jan 29, 2023

@Jaifroid Hey I have a doubt that I am facing. So while changing .on event listener for a specific element suppose there's an element which has (id= prefix), Now when I convert $('#prefix).on() to document.getElementById('prefix') there are code that looks like document.getElementById('prefix').value, So I want to ask can I use document.getElementById once for that element store it in a variable and then use that variable for other part of code.
Sorry this is my first time and this might be a stupid question.

@Jaifroid
Copy link
Member Author

@Abhishek-1337 If you're going to re-use the value in document.getElementById('prefix').value then of course you can assign it to a variable and just use the variable instead of getting the value again each time you need it.

@Rishabhg71
Copy link
Collaborator

@Jaifroid if the issue is still open do you mind giving it to me
i would be happy to this task under your mentorship since i am new to this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup remove-jquery Issues or PRs involving removal of jQuery
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants