Ensure dockerfile serves jsonp with correct MIME type #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
added
build
|
From web searches, it appears it is not possible to change the MIME type of files on gh-pages, though it is possible to contribute a changed MIME type at https://github.com/jshttp/mime-db#adding-custom-media-types. However, the process looks pretty complicated, and if it ever breaks on gh-pages, we can simply rename the files to |
|
There's no real way to know if this one-liner will work until we try it on the live container as part of a release, so will need to be vigilant at release time. @kelson42 As you originally set up our dockerfile and are fluent in Linux, could you take a look at this one-liner? |
|
We just have to test this empirically. |
Jaifroid
deleted the
Ensure-dockerfile-serves-jsonp-files-with-correct-MIME-type
branch
Jaifroid
added a commit
that referenced
this pull request
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should partially fix #1099 for the GHCR container.