-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work towards warc2zim reading #1173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
added
do-not-merge
Sample code
dependencies
Pull requests that update a dependency file
backend
zimit
Code relating to the support of Zimit-style archives
labels
Nov 24, 2023
All issues now fixed in both modes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
dependencies
Pull requests that update a dependency file
zimit
Code relating to the support of Zimit-style archives
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more on track than previous attempts, though not working yet.
It achieves the following:
replay_iframe
inside our iframe, with the src set to the requested document with a rewritten URL likehttp://localhost:8080/kiwix-js/zim_name.zim/C/A/mp_/https://example.com/requested_document/
(all done from within the replayWorker);So, it's progress (painstaking), but missing something vital.