Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update regex to match PhET #1227

Merged
merged 1 commit into from
Mar 9, 2024
Merged

update regex to match PhET #1227

merged 1 commit into from
Mar 9, 2024

Conversation

Greeshmanth1909
Copy link
Contributor

@Greeshmanth1909 Greeshmanth1909 commented Mar 8, 2024 •
edited
Loading

resolve #1157
Updated the regex to also match ractive.js. I was able to view the active content warning when PhET zims were opened in Safe mode.

@Jaifroid Jaifroid added regression Broken things that used to work bug-non-critical For bugs that it would be nice to fix rather than critical to fix labels Mar 9, 2024
Jaifroid
Jaifroid approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you very much! I'll merge after doing a few small tests myself!

@Jaifroid Jaifroid added this to the v4.1 milestone Mar 9, 2024
@Jaifroid Jaifroid merged commit 3b26c6f into kiwix:main Mar 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaifroid Jaifroid Jaifroid approved these changes

Assignees

@Greeshmanth1909 Greeshmanth1909

Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix regression Broken things that used to work
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

Active content warning not detecting PhET ZIMs
2 participants
@Greeshmanth1909 @Jaifroid