Add option to turn off external link warning #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dan-niles Thanks for the PR! I'll take a look as soon as I get a chance. |
|
@dan-niles Apologies for taking so long to look at this. On quick testing, it's working really well, in both SW mode and Safe mode. I'll now look at the code. |
Jaifroid
requested changes
Mar 27, 2024
i18n/es.jsonp.js
Outdated
| @@ -137,6 +139,7 @@ document.localeJson = { | |||
| "dialog-article-readerror-title": "Error al leer artículo", | |||
| "dialog-cancel": "Cancelar", | |||
| "dialog-ok": "OK", | |||
| "dialog-hide": "No vuelvas a preguntar", | |||
There was a problem hiding this comment.
We're using the forma (Usted) form of you in this app, so this needs to be "No vuelva a preguntar".
There was a problem hiding this comment.
I used an online translation tool and wasn't really sure about it. 😅
Thanks for the clarification! Updated in 1c1869b.
|
Tested and working on IE11. |
…ional statement in app.js and uiUtil.js
Jaifroid
approved these changes
Mar 28, 2024
|
@Jaifroid Yes, all good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #891
This PR adds the option to turn off the external link warning.