-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CONTRIBUTING.md : WIP #800
Added CONTRIBUTING.md : WIP #800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this useful PR. Just some minor changes as suggested in the review comments, please.
@Jaifroid thanks for your useful review. Will make the necessary changes. |
@Jaifroid pushed another commit with the required changes. Please review at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it's looking good now! I'll request a review from Mossroy.
There's a file with the same name in https://github.com/kiwix/overview/blob/master/CONTRIBUTING.md , that covers the basic steps for creating a PR. I prefer your file, but it might be worth pointing to an external documentation that explains how to create a PR on github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the latest. All fine for me now!
@gaurav7019 Thanks for this PR! We can merge it now. Are you ready for me to squash/merge (it will still appear as your PR)? |
Yeah sure, go ahead. It was a great first experience. 😄 |
Fixes #799
Added the CONTRIBUTING.md file in the repo and linked it inside the newly created "Contributing" section of the README.md
Changes
Flags
Needs review in the following changes:
Related Issues