-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing parameters to kiwix-serve.1 #626
Conversation
@iArchitSharma Thank you for your PR, we will do our best to review it quickly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started reading the updated man page and wrote a couple of comments until I figured out that the content of the man page differs from the online documentation. Ideally there should be a shared source for documentation content (e.g. the man page is generated from the .rst file). If that is too much to ask for this PR, I think that at least the man page must contain the same text as the online documentation.
@veloman-yunkan I have updated the manpage, is it good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also include the link to the online documentation in the DOCUMENTATION section.
@veloman-yunkan Done with everything you told! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You misunderstood one of my previous comments. After you fix it please squash all your commits into one and the PR will be good to merge.
@veloman-yunkan Is it good now? |
Can you tell me how I can squash all of my commits? I searched the web, but it didn't help. |
It is a little short of being good:
|
|
Also |
@veloman-yunkan done! |
still not able to, can you merge without me stashing all the commits? |
@iArchitSharma No, because this will pollute the git revision log. What is the problem? You don't use git on the command line? |
I use git but have never squashed before |
Finally done with squash too! |
But the result is still not available on GitHub. Note that you have to provide the |
Item 2 was not addressed. |
Done |
All done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with me!
I really appreciate your assistance. I've learned a lot |
Fixes #609