[fixes]ZIM size being advertized inconsistently between MB and MiB #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harsha-mangena Thank you for your PR but please complete your PR by updating the cacheid (read the README for the details). |
veloman-yunkan
force-pushed
the
i1095-consistancy-issue
branch
from
3255148 to
9115504
Compare
Switched display of ZIM sizes from decimal (MB) to binary (MiB) units. Also made the size value to be formatted in a more human friendly way (fractional part is shown only to provide at least three significant digits).
veloman-yunkan
force-pushed
the
i1095-consistancy-issue
branch
from
9115504 to
97832c8
Compare
|
@veloman-yunkan Thx for the cacheid. Good to merge? |
|
@harsha-mangena Thanks for the PR! I improved the commit message as well as changed the formatting of the size value (the fractional part is presented so as to ensure at least 3 significant digits). I also updated the cacheids in the unit tests. |
veloman-yunkan
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1095