Catalog search without support for Xapian boolean operators #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to test book descriptions words that serve as keywords for query syntax with boolean operators (or, and, not, xor, near, adj) enabled. Note that the change in indexed text has lead to the change in the order of returned results.
veloman-yunkan
force-pushed
the
catalog_search_without_boolean_operators
branch
from
756c48c to
01bda6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1137 +/- ##
=======================================
Coverage 41.43% 41.43%
=======================================
Files 59 59
Lines 4245 4245
Branches 2323 2323
=======================================
Hits 1759 1759
Misses 990 990
Partials 1496 1496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104
Now all words in the query (
qparameter) of the/catalog/v2/entriesAPI endpoint should act as search terms (i.e. none will be interpreted as a Xapian query operator).