Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a few dependencies in the workflows #1168

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

kelson42
Copy link
Collaborator

@kelson42 kelson42 commented Dec 20, 2024

@rgaudin Removed HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1 and not sure about that move, therefore putting you as reviewer.

@kelson42 kelson42 force-pushed the remove-set-output-in-workflows branch from 0e8a4fe to 8fdaa5f Compare December 20, 2024 07:31
@kelson42 kelson42 changed the title Remove set output in workflows Remove set-output in workflows Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.47%. Comparing base (a809c67) to head (f693f70).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   41.47%   41.47%           
=======================================
  Files          59       59           
  Lines        4272     4272           
  Branches     2336     2336           
=======================================
  Hits         1772     1772           
  Misses        999      999           
  Partials     1501     1501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 changed the title Remove set-output in workflows Update a few dependencies in the workflows Dec 20, 2024
@kelson42 kelson42 requested a review from rgaudin December 20, 2024 08:24
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; this was part of a workaround

@kelson42 kelson42 merged commit 81b579c into main Dec 20, 2024
15 checks passed
@kelson42 kelson42 deleted the remove-set-output-in-workflows branch December 20, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants