Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pinning of Sphinx<4 #736

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Remove pinning of Sphinx<4 #736

merged 1 commit into from
Mar 28, 2022

Conversation

mgautierfr
Copy link
Member

@mgautierfr mgautierfr commented Mar 28, 2022

Fix #735

It seems the issue is a dependencies version problem. (See readthedocs/readthedocs.org#9038)
This issue is fixed with Sphinx 4.0.2 but we were forcing sphinx to be <4 (probably for the same kind of problem)
We could force Jinja2<3.0 as proposed in readthedocs issue.
However, I've decided to remove the Sphinx<4 to compile doc with up to date dependencies. But I'm open to counter-argument to force Jinja2<3.0

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #736 (59364a7) into master (49f24d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   58.31%   58.31%           
=======================================
  Files          56       56           
  Lines        3697     3697           
  Branches     2069     2069           
=======================================
  Hits         2156     2156           
  Misses       1540     1540           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f24d1...59364a7. Read the comment docs.

@mgautierfr mgautierfr marked this pull request as ready for review March 28, 2022 13:36
It seems we add this pinning to fix a dependencies issue.
Let's remove it.
@mgautierfr mgautierfr requested a review from kelson42 March 28, 2022 13:37
@mgautierfr mgautierfr changed the title [WIP] Remove pinning of Sphinx<4 Remove pinning of Sphinx<4 Mar 28, 2022
@kelson42 kelson42 merged commit 574c1ad into master Mar 28, 2022
@kelson42 kelson42 deleted the pin_jinja2_doc branch March 28, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix readthedocs documentation generation
2 participants