URI encoding of redirects #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 71.41% // Head: 71.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 71.41% 71.39% -0.03%
==========================================
Files 53 53
Lines 3740 3740
Branches 2077 2077
==========================================
- Hits 2671 2670 -1
- Misses 1067 1068 +1
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@mgautierfr @veloman-yunkan Probably not related to this PR, but worried that the macOS CI fails. |
mgautierfr
requested changes
Jan 10, 2023
Updated the create_corner_cases_zim_file to work with the latest (v3.1.3) release of zimwriterfs.
Specifying the = symbol with single-character options makes that character included in the option value (e.g. -l=en results in the language of the ZIM file being set to =en).
veloman-yunkan
force-pushed
the
uri_encoded_redirections
branch
from
91e2ffe to
8eb5273
Compare
|
No changes, only rebased after merging #857. |
|
@mgautierfr Good to merge then? |
mgautierfr
approved these changes
Jan 10, 2023
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first on of expected multiple fixes addressing #775.
This particular fix should at least eliminate @DarkmatterUAE's pain described at kiwix/kiwix-tools#589 😃. I tested it with the smaller and newer wikipedia_en_all_mini_2023-01.zim instead of wikipedia_en_all_nopic_2022-01.zim used in the original ticket, but they shouldn't be different with the respect to the data that triggered the bug.
Fixes kiwix/kiwix-tools#589