Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really enable Chromium to display PDFs in the viewer iframe #930

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Really enable Chromium to display PDFs in the viewer iframe #930

merged 1 commit into from
Apr 11, 2023

Commits on Apr 10, 2023

  1. Really enable Chromium to display PDFs in the viewer iframe 

    The previous "fix" (merged PR #924) was buggy. It not only didn't work
in Chromium v90, but in more recent versions too.

I verified that this fix works in Firefox (v111) and Chromium (v90):

- Attempts by the ZIM content to break out of the viewer iframe are
blocked.
- PDFs are displayed in the viewer.
    @veloman-yunkan
    veloman-yunkan committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    9fd7f7d View commit details
    Browse the repository at this point in the history