Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up sql functions for computing performance matrix #48

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

elfkuzco
Copy link
Collaborator

@elfkuzco elfkuzco commented Sep 5, 2024

Rationale

This PR creates functions required to compute the performance of mirrors against country and region in the database. Through these functions, a table can be generated on Metabase to generate the rows. The functions are written in SQL as there is no native way of interacting with Python through Metabase. This lays the foundation for #40

NOTE
These functions assume that the mirror brain attributes as described in kiwix/container-images#263 have been set on the database.

@elfkuzco elfkuzco requested a review from rgaudin September 5, 2024 06:59
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (b522855) to head (0c493b2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   69.66%   69.66%           
=======================================
  Files          30       30           
  Lines         946      946           
  Branches       93       93           
=======================================
  Hits          659      659           
  Misses        267      267           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow impressive work!

It all makes sense and looks good to me.

@elfkuzco elfkuzco merged commit e1cdbc2 into main Sep 5, 2024
5 checks passed
@elfkuzco elfkuzco deleted the performance-matrix branch September 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants