Skip to content

fix: remove Gemini-specific validation and logging from OpenAI payload #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiyo-e merged 1 commit into from
Jun 8, 2025
Merged

fix: remove Gemini-specific validation and logging from OpenAI payload #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 6 additions & 22 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,26 +184,6 @@ app.post('/v1/messages', async (c) => {
}
if (tools.length > 0) openaiPayload.tools = tools

// Additional validation for Gemini compatibility
if (baseUrl.includes('gemini') || baseUrl.includes('google')) {
// Gemini-specific adjustments
if (openaiPayload.max_tokens === undefined) {
// Gemini might require max_tokens
openaiPayload.max_tokens = 4096
}

// Log for debugging Gemini issues
console.log('Sending to Gemini-like API:', {
model: openaiPayload.model,
messageCount: openaiPayload.messages.length,
hasTools: !!openaiPayload.tools,
toolCount: openaiPayload.tools?.length || 0,
messageRoles: openaiPayload.messages.map((m: any) => m.role),
hasMaxTokens: !!openaiPayload.max_tokens,
temperature: openaiPayload.temperature
})
}

debug('OpenAI payload:', openaiPayload)

const headers: Record<string, string> = {
Expand Down Expand Up @@ -507,7 +487,11 @@ app.post('/v1/messages', async (c) => {
console.error('Streaming error:', error)
controller.error(error)
} finally {
controller.close()
try {
controller.close()
} catch {
// Controller already closed, ignore
}
}
}
}), {
Expand All @@ -533,4 +517,4 @@ function mapStopReason(finishReason: string): string {
}
}

export default app
export default app