Skip to content

Commit

Permalink
doc: remove legacy WPT integration guide
Browse files Browse the repository at this point in the history
Point to the new guide in test/wpt/README.md instead.

PR-URL: nodejs#24035
Refs: nodejs#23192
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
  • Loading branch information
joyeecheung authored and kiyomizumia committed Nov 15, 2018
1 parent 8371f32 commit df2ab63
Showing 1 changed file with 1 addition and 22 deletions.
23 changes: 1 addition & 22 deletions doc/guides/writing-tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -310,27 +310,7 @@ functions worked correctly with the `beforeExit` event, then it might be named

### Web Platform Tests

Some of the tests for the WHATWG URL implementation (named
`test-whatwg-url-*.js`) are imported from the [Web Platform Tests Project][].
These imported tests will be wrapped like this:

```js
/* The following tests are copied from WPT. Modifications to them should be
upstreamed first. Refs:
https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html
License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html
*/
/* eslint-disable */

// Test code

/* eslint-enable */
```

To improve tests that have been imported this way, please send
a PR to the upstream project first. When the proposed change is merged in
the upstream project, send another PR here to update Node.js accordingly.
Be sure to update the hash in the URL following `WPT Refs:`.
See [`test/wpt`](../../test/wpt/README.md) for more information.

## C++ Unit test

Expand Down Expand Up @@ -418,7 +398,6 @@ To generate a test coverage report, see the

[ASCII]: http://man7.org/linux/man-pages/man7/ascii.7.html
[Google Test]: https://github.com/google/googletest
[Web Platform Tests Project]: https://github.com/w3c/web-platform-tests/tree/master/url
[`common` module]: https://github.com/nodejs/node/blob/master/test/common/README.md
[all maintained branches]: https://github.com/nodejs/lts
[node.green]: http://node.green/
Expand Down

0 comments on commit df2ab63

Please sign in to comment.