Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Notebook 7 uses localhost:8888/nbclassic #86

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

kiyoon
Copy link
Owner

@kiyoon kiyoon commented Jul 19, 2023

Now, users who install notebook will install Notebook 7 by default. Thus, this PR changes the default options so that it will work with URL http://localhost:8888/nbclassic.

Make sure to install pip install --upgrade notebook nbclassic

@fecet
Copy link
Contributor

fecet commented Jul 20, 2023

It seems that we currently don't have any other options, or we could simply restrict the installation of the notebook to version 6.5.4. It doesn't appear that nbclassic would bring us any benefits, right?

@kiyoon
Copy link
Owner Author

kiyoon commented Jul 20, 2023

As far as I know, nbclassic will be maintained for another 2 years. And there may be people who actually want to use Notebook 7 and we don't want them to uninstall it just for Jupynium.

@fecet
Copy link
Contributor

fecet commented Jul 20, 2023

So one modify notebook_URL if they still want to use notebook v6? It looks good to me.

@kiyoon kiyoon merged commit 0e55a37 into master Jul 20, 2023
14 checks passed
@kiyoon kiyoon deleted the fix/notebook7 branch June 15, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants