Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Set encoding #25

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Fix Set encoding #25

merged 3 commits into from
Nov 3, 2024

Conversation

gburca
Copy link
Contributor

@gburca gburca commented Aug 6, 2024

  • The bits were in the wrong order before.

@gburca
Fix Set encoding
ff7f827 
- The bits were in the wrong order before.
@gburca
Handle decoding nullable types
2bd2b8f 
- If it's encoded with None, it should be decoded as None, not as the
  nullValue.
@gburca
Handle messages with padding
61a0579 
- The encoding ignored blockLength
@kizzx2 kizzx2 merged commit 4f34455 into kizzx2:master Nov 3, 2024
@kizzx2
Copy link
Owner

kizzx2 commented Nov 3, 2024

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kizzx2 kizzx2 kizzx2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gburca @kizzx2