Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149.
Assumption: Does idna.encode() always throw an exception for strings that contain invalid punycode and/or unconvertible unicode (such as emojis)?
is_idna(s) returns True if a given string
s
can be encoded by idna.encode() without error, and at least one of its encoded labels begins withb"xn--"
.A more efficient implementation would be to reuse portions of idna.encode() so that the per-label
b"xn--"
checks can be done before doings = b'.'.join(result)
for the final valid_string_length() check.