Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'grandPlan' property to Grand Plan children #53

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

kkartch0
Copy link
Owner

@kkartch0 kkartch0 commented Feb 2, 2025

All children of each GrandPlan now get added a "grandPlan" property when the grand plan is recalculated.

Fixes #52.

@kkartch0 kkartch0 requested a review from Copilot February 2, 2025 13:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/pacerPlanStringParsing.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

test/pacerPlanStringParsing.createPacerPlanFromString.test.ts:64

  • The word 'quantity' is misspelled as 'quanity'.
it("when some tasks are singular quantity: should create a PacerPlan object from a string representation", () => {
@kkartch0 kkartch0 merged commit df574a2 into main Feb 2, 2025
1 check passed
@kkartch0 kkartch0 deleted the kkartch0/issue52 branch February 2, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "grandPlan" property to all the children of each GrandPlan.
1 participant