Allow custom sequence bindings starting with non-modified keys #743
+51
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-character bindings of keys pressed without a modifier are already allowed (emacs, vi command, vi insert), but these don't work for multi-character sequences whose first character is not modified. The current behavior for them just prints the first character.
This change modifies
InputState::emacs
andInputState::vi_insert
to check whether an unmodified key is the beginning of a custom sequence binding before inserting.If a sequence binding is started and fails to find a match, all printable keys pressed are emitted.