Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose getStreamURL for use elsewhere #103

Merged
merged 2 commits into from
Aug 22, 2020

Conversation

tystuyfzand
Copy link
Contributor

Description

getStreamURL in client.go was updated to allow the use of the function outside of the package, for example in an application that handles the http connection itself (with headers, re-connection, etc). It was also updated to allow a context and non-context argument style as the other functions use.

Issues to fix

None

Reminding

Something you can do before PR to reduce time to merge

  • run "make build" to build the code (DONE)
  • run "make format" to reformat the code (DONE)
  • run "make lint" if you are using unix system (Windows)
  • run "make test-integration" to pass all tests (Unable to run)

@tystuyfzand
Copy link
Contributor Author

Looks like the integration tests are failing due to unrelated issues as well.

@Julian-Chu
Copy link
Collaborator

Looks like the integration tests are failing due to unrelated issues as well.

Yes, I think PR itself has no problem. I would like to merge it first, and do test after fixing the unrelated issue.

Thanks for the contribution!

@Julian-Chu Julian-Chu merged commit cf2c575 into kkdai:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants