Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Formats and AdaptiveFormats to Video #97

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Conversation

Julian-Chu
Copy link
Collaborator

Description

add Formats and AdaptiveFormats to Video and
expose Formats and AdaptiveFormats of Video to user

Issues to fix

Please link issues this PR will fix:
#86

@greentornado
Copy link

Please merge bros :D

video.go Outdated Show resolved Hide resolved
@corny corny self-requested a review August 13, 2020 10:20
@corny
Copy link
Collaborator

corny commented Aug 13, 2020

@Julian-Chu I added another commit. What do you think?

@corny corny requested review from corny and removed request for corny August 13, 2020 10:21
@corny corny force-pushed the master branch 2 times, most recently from 4a5048c to d5e4a77 Compare August 13, 2020 10:30
@Julian-Chu
Copy link
Collaborator Author

LGTM.

@Julian-Chu Julian-Chu merged commit 40fdf77 into kkdai:master Aug 13, 2020
@greentornado
Copy link

Awesome. Please release then 👍

@Julian-Chu
Copy link
Collaborator Author

@greentornado you can download the release v2 , later I will try to use goreleaser to release same thing again

@corny
Copy link
Collaborator

corny commented Aug 13, 2020

I built the binaries with Go 1.15 and uploaded them.

@corny
Copy link
Collaborator

corny commented Aug 13, 2020

Strange ... the release data disappared. I did another v2.0.0 release.

@greentornado
Copy link

greentornado commented Aug 16, 2020

I ran go get -u github.com/kkdai/youtube but it stucked at 1.2.4 :D. Please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants