Merge pull request #649 from kkoomen/feature/cpp-fixes

Handle unnamed function params for c++
kkoomen · Dec 29, 2023 · 7dc73a1 · 7dc73a1
2 parents 153cb14 + 8fce544
commit 7dc73a1
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 8 deletions.
diff --git a/helper/src/cpp/docs/doxygen_cpp_comment_exclamation.yaml b/helper/src/cpp/docs/doxygen_cpp_comment_exclamation.yaml
@@ -33,7 +33,7 @@ templates:
       {% endif %}
       {% if params %}
         {% for param in params %}
-      //! {{ char }}param[[TODO:direction]] {{ param.name }} [TODO:description]
+      //! {{ char }}param[[TODO:direction]] {{ param.name | default(value="[TODO:name]") }} [TODO:description]
         {% endfor %}
       {% endif %}
       {% if return_type %}

diff --git a/helper/src/cpp/docs/doxygen_cpp_comment_slash.yaml b/helper/src/cpp/docs/doxygen_cpp_comment_slash.yaml
@@ -33,7 +33,7 @@ templates:
       {% endif %}
       {% if params %}
         {% for param in params %}
-      /// {{ char }}param[[TODO:direction]] {{ param.name }} [TODO:description]
+      /// {{ char }}param[[TODO:direction]] {{ param.name | default(value="[TODO:name]") }} [TODO:description]
         {% endfor %}
       {% endif %}
       {% if return_type %}

diff --git a/helper/src/cpp/docs/doxygen_cpp_comment_slash_banner.yaml b/helper/src/cpp/docs/doxygen_cpp_comment_slash_banner.yaml
@@ -33,7 +33,7 @@ templates:
       {% endif %}
       {% if params %}
         {% for param in params %}
-      /// {{ char }}param[[TODO:direction]] {{ param.name }} [TODO:description]
+      /// {{ char }}param[[TODO:direction]] {{ param.name | default(value="[TODO:name]") }} [TODO:description]
         {% endfor %}
       {% endif %}
       {% if return_type %}

diff --git a/helper/src/cpp/docs/doxygen_javadoc.yaml b/helper/src/cpp/docs/doxygen_javadoc.yaml
@@ -33,7 +33,7 @@ templates:
       {% endif %}
       {% if params %}
         {% for param in params %}
-       * {{ char }}param[[TODO:direction]] {{ param.name }} [TODO:description]
+       * {{ char }}param[[TODO:direction]] {{ param.name | default(value="[TODO:name]") }} [TODO:description]
         {% endfor %}
       {% endif %}
       {% if return_type %}

diff --git a/helper/src/cpp/docs/doxygen_javadoc_banner.yaml b/helper/src/cpp/docs/doxygen_javadoc_banner.yaml
@@ -33,7 +33,7 @@ templates:
       {% endif %}
       {% if params %}
         {% for param in params %}
-       * {{ char }}param[[TODO:direction]] {{ param.name }} [TODO:description]
+       * {{ char }}param[[TODO:direction]] {{ param.name | default(value="[TODO:name]") }} [TODO:description]
         {% endfor %}
       {% endif %}
       {% if return_type %}

diff --git a/helper/src/cpp/docs/doxygen_javadoc_no_asterisk.yaml b/helper/src/cpp/docs/doxygen_javadoc_no_asterisk.yaml
@@ -33,7 +33,7 @@ templates:
       {% endif %}
       {% if params %}
         {% for param in params %}
-      {{ char }}param[[TODO:direction]] {{ param.name }} [TODO:description]
+      {{ char }}param[[TODO:direction]] {{ param.name | default(value="[TODO:name]") }} [TODO:description]
         {% endfor %}
       {% endif %}
       {% if return_type %}

diff --git a/helper/src/cpp/docs/doxygen_qt.yaml b/helper/src/cpp/docs/doxygen_qt.yaml
@@ -33,7 +33,7 @@ templates:
       {% endif %}
       {% if params %}
         {% for param in params %}
-       * {{ char }}param[[TODO:direction]] {{ param.name }} [TODO:description]
+       * {{ char }}param[[TODO:direction]] {{ param.name | default(value="[TODO:name]") }} [TODO:description]
         {% endfor %}
       {% endif %}
       {% if return_type %}

diff --git a/helper/src/cpp/docs/doxygen_qt_no_asterisk.yaml b/helper/src/cpp/docs/doxygen_qt_no_asterisk.yaml
@@ -33,7 +33,7 @@ templates:
       {% endif %}
       {% if params %}
         {% for param in params %}
-      {{ char }}param[[TODO:direction]] {{ param.name }} [TODO:description]
+      {{ char }}param[[TODO:direction]] {{ param.name | default(value="[TODO:name]") }} [TODO:description]
         {% endfor %}
       {% endif %}
       {% if return_type %}

diff --git a/test/filetypes/cpp/functions.vader b/test/filetypes/cpp/functions.vader
@@ -108,3 +108,20 @@ Expect cpp (generated comment with @brief and @param tag):
    * @param[[TODO:direction]] x [TODO:description]
    */
   void foo( int x = y );
+
+# ==============================================================================
+# Functions with unnamed parameters
+# ==============================================================================
+Given cpp (Functions with unnamed parameter):
+  Game(const Game &)=default;
+
+Do (trigger doge):
+  \<C-d>
+
+Expect cpp (generated comment with @brief and @param tag):
+  /**
+   * @brief [TODO:summary]
+   *
+   * @param[[TODO:direction]] [TODO:name] [TODO:description]
+   */
+  Game(const Game &)=default;