Fixed potential issues in examples/show_progress.py #829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
examples/show_progress.py
file monkey patches modules usinggevent.monkey.patch_all()
, implementing it like this in a real project can lead to weird errors:The above error occurs when the project includes something like this codeblock after the patching has been done:
After some trial and error, I found that it's only necessary to patch the
selectors
module instead of runningpatch_all()
.I implemented this in a context manager that restores the original
selectors
module afterwards, to avoid any other potential issues further down in a project when this module has been patched for no reason.I also moved the main logic to a separate function, so that this issue can be tested more easily with a scratch file like this:
This resolves the error I mentioned, and the progress bar still works correctly.
Thanks for providing this repository, it has been nice using ffmpeg video generation in my project while having the progress bar instead of the default output.