This repository has been archived by the owner on Feb 12, 2025. It is now read-only.
fix: storage address #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobez
suggested changes
Aug 23, 2023
crates/ef-testing/src/models/case.rs
Outdated
| @@ -58,11 +57,19 @@ async fn handle_pre_state( | |||
| //// 'handle' methods attempt to abstract the data coming from BlockChainTestCase | |||
| //// from more general logic that can be used across tests | |||
| impl BlockchainTestCase { | |||
| fn test(&self, test_name: &str) -> Result<BlockchainTest, ef_tests::Error> { | |||
| let test = self.tests.get(test_name).ok_or_else(|| { | |||
| ef_tests::Error::Assertion(format!("failed test {}: missing pre state", test_name)) | |||
There was a problem hiding this comment.
is this the right error message for this case?
greged93
force-pushed
the
fix/storage-address
branch
from
288237d to
396b7a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the post state verification from accessing the storage value at offset = 1, if the post state expected value is smaller than U128::MAX. Also added some light cleaning (removing unnecessary Arc, added test case for mul file, ...).
Time spent on this PR: 0.2 day
Resolves: #14
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Fixes the storage access issue du to expected value lower than U128::MAX.
Does this introduce a breaking change?