Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vmtests #76

Merged
merged 4 commits into from
Sep 6, 2023
Merged

feat: add vmtests #76

merged 4 commits into from
Sep 6, 2023

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Sep 6, 2023

Adds the VMTests to the current runner, with all skipped tests linked to a PR.
Time spent on this PR: 3 days

Resolves: #28

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Runner can run VMTests.

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Contributor

@ftupas ftupas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question 🙂

crates/ef-testing/src/models/case.rs Show resolved Hide resolved
crates/ef-testing/tests/tests.rs Outdated Show resolved Hide resolved
Co-authored-by: ftupas <35031356+ftupas@users.noreply.github.com>
ftupas
ftupas previously approved these changes Sep 6, 2023
Copy link
Contributor

@ftupas ftupas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@greged93 greged93 added this pull request to the merge queue Sep 6, 2023
Merged via the queue into kkrt-labs:main with commit 9181fb1 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epic: add VMTests
2 participants