Skip to content
This repository has been archived by the owner on Feb 12, 2025. It is now read-only.

refactor flow for test #9

Merged
merged 2 commits into from
Aug 23, 2023
Merged

refactor flow for test #9

merged 2 commits into from
Aug 23, 2023

Conversation

jobez
Copy link
Contributor

@jobez jobez commented Aug 23, 2023

Time spent on this PR: 1 beautiful day

Resolves: #

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

  • Differentiate the handle phase of a step from its inner logic, to enable inner logic reuse for different kinds of tests
  • Refactor general flow into handle phases

Does this introduce a breaking change?

  • Yes
  • No

@jobez jobez requested a review from greged93 August 23, 2023 03:49
@jobez jobez force-pushed the test_flow_cleanup branch 3 times, most recently from bbcd388 to a57fa92 Compare August 23, 2023 04:21
@jobez jobez force-pushed the test_flow_cleanup branch from a57fa92 to 9e50c20 Compare August 23, 2023 04:24
Copy link
Contributor Author

@jobez jobez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some justifications/motivations for changes

Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some smol changes to be able to branch out of main, if you don't agree with them we can update later!

@greged93 greged93 merged commit 8d64b0a into main Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants