moved both assertions back to wrapping shl test, added test case for …

…shift > 255
kkrt-labs · Sep 3, 2023 · b43ab1e · b43ab1e
1 parent 6f91953
commit b43ab1e
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/crates/evm/src/tests/test_instructions/test_comparison_operations.cairo b/crates/evm/src/tests/test_instructions/test_comparison_operations.cairo
@@ -215,7 +215,7 @@ fn test_exec_gt_true() {
 
 #[test]
 #[available_gas(20000000)]
-fn test_exec_shl_stack() {
+fn test_exec_shl_wrapping() {
     // Given 
     let mut ctx = setup_execution_context();
     ctx.stack.push(0xff00000000000000000000000000000000000000000000000000000000000000).unwrap();
@@ -226,30 +226,37 @@ fn test_exec_shl_stack() {
 
     // Then
     assert(ctx.stack.len() == 1, 'stack should have one element');
+    assert(
+        ctx
+            .stack
+            .peek()
+            .unwrap() == 0xf000000000000000000000000000000000000000000000000000000000000000,
+        'stack top should be 0xf00000...'
+    );
 }
 
 #[test]
 #[available_gas(20000000)]
-fn test_exec_shl_result() {
+fn test_exec_shl_shift_too_large() {
     // Given 
     let mut ctx = setup_execution_context();
     ctx.stack.push(0xff00000000000000000000000000000000000000000000000000000000000000).unwrap();
-    ctx.stack.push(4_u256).unwrap();
+    ctx.stack.push(256_u256).unwrap();
 
     // When 
     ctx.exec_shl();
 
     // Then
+    assert(ctx.stack.len() == 1, 'stack should have one element');
     assert(
         ctx
             .stack
             .peek()
-            .unwrap() == 0xf000000000000000000000000000000000000000000000000000000000000000,
-        'stack top should be 0xf00000...'
+            .unwrap() == 0,
+        'if shift > 255 should return 0'
     );
 }
 
-
 #[test]
 #[available_gas(20000000)]
 fn test_exec_gt_false() {