Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ExecutionContext may not have both child_context and parent_context fields as Nullable<ExecutionContext> #387

Closed
Eikix opened this issue Oct 3, 2023 · 0 comments · Fixed by #388
Assignees
Labels
bug Something isn't working

Comments

@Eikix
Copy link
Member

Eikix commented Oct 3, 2023

Bug Report

Currently, the ExecutionContext has both a parent_context and child_context field, in order to be able to:

  • go up a context when a subcontext ends,
  • access return data of a child context inside a parent context using returndatasize and returndatacopy

We cannot currently have two pointers pointing at the same struct.

image image

Solution

Only have parent_context field and instead of child context, have a child_return_data: Option<Span>

@Eikix Eikix added the bug Something isn't working label Oct 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Oct 3, 2023
@Eikix Eikix self-assigned this Oct 3, 2023
@Eikix Eikix moved this from 🆕 Backlog to 🏗 In progress in Kakarot on Starknet Oct 3, 2023
@Eikix Eikix moved this from 🏗 In progress to 👀 In review in Kakarot on Starknet Oct 3, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Kakarot on Starknet Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant