Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor child context to be child context return data #388

Merged

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Oct 3, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #387

What is the new behavior?

  • Each context has only a parent context field that tracks its parent inside a Nullable smart pointer
  • Instead of having a child context field, it simply has a child_context_return_data

Does this introduce a breaking change?

  • Yes
  • No

@Eikix Eikix requested a review from ClementWalter as a code owner October 3, 2023 07:31
enitrat
enitrat previously approved these changes Oct 4, 2023
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Can you add some info in the docs about this design choice later?

Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@enitrat enitrat added this pull request to the merge queue Oct 4, 2023
Merged via the queue into kkrt-labs:main with commit 3a4603c Oct 4, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ExecutionContext may not have both child_context and parent_context fields as Nullable<ExecutionContext>
2 participants