refactor: decode_legacy_tx
for consistency with typed transactions
#1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Refactor
decode_legacy_tx
for consistency with typed transactionsPlease check the type of change your PR introduces:
The function has been splitted into two steps
encoded_tx_data
and returns the decoded data.crates/utils/src/eth_transaction/transaction.cairo
to decode transaction fields.Resolves: #979
Refactor
eip2930.cairo
Does this introduce a breaking change?
This change is