This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
implement LT opcode #221
Merged
implement LT opcode #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glihm
commented
Aug 28, 2023
crates/evm/src/tests/test_instructions/test_comparison_operations.cairo
Outdated
Show resolved
Hide resolved
enitrat
reviewed
Aug 28, 2023
crates/evm/src/tests/test_instructions/test_comparison_operations.cairo
Outdated
Show resolved
Hide resolved
|
Hey @glihm I hope you had a good flight back home :) Let me know if you can finish this one soon |
|
Snapshot Comparison Report: No changes in gas consumption. |
enitrat
reviewed
Sep 5, 2023
crates/evm/src/tests/test_instructions/test_comparison_operations.cairo
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #5
What is the new behavior?
exec_ltreturns 1 if a < b, returns 1. Otherwise, 0.Does this introduce a breaking change?