Feat: Implemented EOA Constructor and get_evm_address #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snapshot Comparison Report: No changes in gas consumption. |
enitrat
reviewed
Aug 30, 2023
|
I do see that we had in the cairo0 impl a |
enitrat
reviewed
Sep 4, 2023
| } | ||
|
|
||
| #[external(v0)] | ||
| impl ExternallyOwnedAccount of super::IExternallyOwnedAccount<ContractState> { | ||
| /// Returns an empty span, required for the EXTCODE opcode | ||
| fn get_evm_address(self: @ContractState) -> EthAddress { |
There was a problem hiding this comment.
If we have a common library for both EOAs and Account contracts, I'd rather make an external component for that to share code and avoid maintaining twice the same thing. Should be ready next week-ish
|
Putting this PR review on hold until we have Cairo Components in SSJ |
|
Closing this for now as it's outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the constructor for EOA (previously initialize()):
https://github.com/kkrt-labs/kakarot/blob/c0c80301d4dfe384247b423a3bc2726522b5d1a8/src/kakarot/accounts/eoa/externally_owned_account.cairo#L15
And get_evm_address function:
https://github.com/kkrt-labs/kakarot/blob/c0c80301d4dfe384247b423a3bc2726522b5d1a8/src/kakarot/accounts/eoa/externally_owned_account.cairo#L117
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #216 #211
What is the new behavior?
Does this introduce a breaking change?