Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

dev: implement Into<bool,u256> trait #240

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Conversation

khaeljy
Copy link
Contributor

@khaeljy khaeljy commented Sep 1, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #239

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Snapshot Comparison Report:

No changes in gas consumption.

crates/utils/src/traits.cairo Outdated Show resolved Hide resolved
@khaeljy khaeljy requested a review from enitrat September 1, 2023 20:05
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@enitrat enitrat added this pull request to the merge queue Sep 1, 2023
Merged via the queue into kkrt-labs:main with commit 1306fd5 Sep 1, 2023
@khaeljy khaeljy deleted the into-bool-u32 branch September 2, 2023 05:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: implement Into<bool,u256> trait
2 participants