feat: implement the test suite for MLOAD opcode #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snapshot Comparison Report: No changes in gas consumption. |
khaeljy
commented
Sep 2, 2023
crates/evm/src/tests/test_instructions/test_memory_operations.cairo
Outdated
Show resolved
Hide resolved
crates/evm/src/tests/test_instructions/test_memory_operations.cairo
Outdated
Show resolved
Hide resolved
ClementWalter
requested changes
Sep 4, 2023
enitrat
reviewed
Sep 4, 2023
crates/evm/src/tests/test_instructions/test_memory_operations.cairo
Outdated
Show resolved
Hide resolved
crates/evm/src/tests/test_instructions/test_memory_operations.cairo
Outdated
Show resolved
Hide resolved
crates/evm/src/tests/test_instructions/test_memory_operations.cairo
Outdated
Show resolved
Hide resolved
crates/evm/src/tests/test_instructions/test_memory_operations.cairo
Outdated
Show resolved
Hide resolved
crates/evm/src/tests/test_instructions/test_memory_operations.cairo
Outdated
Show resolved
Hide resolved
enitrat
reviewed
Sep 6, 2023
crates/evm/src/tests/test_instructions/test_memory_operations.cairo
Outdated
Show resolved
Hide resolved
|
Moving discussion and review to #266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #245
What is the new behavior?
Does this introduce a breaking change?