This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
implement 0x17 - OR opcode #12 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Noel, nice to see you here taking some initiatives! Before opening PRs, could you make sure that there is an existing issue and that you can ask to be assigned on it? This makes the open contributions easier to manage :) If the issue doesn't exist yet, you can go to https://evm.codes, and copy-paste the corresponding opcode to the issue (you can copy the HTML code of the block to get a nice formatting) After that, when you open a PR, you need to link the issue with the syntax |
enitrat
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Can you add a testcase with values more complex than 0 and 1 ?
e.g from the legacy implementation: 0x89 | 0xC5 = 0xCD
enitrat
reviewed
Sep 6, 2023
crates/evm/src/tests/test_instructions/test_comparison_operations.cairo
Outdated
Show resolved
Hide resolved
crates/evm/src/tests/test_instructions/test_comparison_operations.cairo
Outdated
Show resolved
Hide resolved
danilowhk
reviewed
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added OR opcode
Enhancement OpCode
Please check the type of change your PR introduces: