Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: bytecode storage #372

Merged
merged 12 commits into from
Oct 2, 2023
Merged

docs: bytecode storage #372

merged 12 commits into from
Oct 2, 2023

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 26, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@enitrat enitrat force-pushed the docs/bytecode-storage branch from 1081959 to 1e63ecc Compare September 26, 2023 11:21
@enitrat enitrat force-pushed the docs/bytecode-storage branch from 0f8f566 to c0aeed3 Compare September 26, 2023 11:23
@enitrat enitrat marked this pull request as ready for review September 27, 2023 08:02
@enitrat enitrat changed the title feat: bytecode storage docs: bytecode storage Sep 27, 2023
@enitrat enitrat requested a review from Eikix September 27, 2023 08:39
Eikix
Eikix reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These documents are great!

enitrat and others added 2 commits September 28, 2023 10:31
@enitrat
Address PR review
be5e12a
@enitrat @Eikix
Apply suggestions from code review
523e701 
Co-authored-by: Elias Tazartes <66871571+Eikix@users.noreply.github.com>
@enitrat
Copy link
Contributor Author

enitrat commented Oct 2, 2023

@Eikix last check and merge?

Eikix
Eikix approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 639a70b Oct 2, 2023
4 checks passed
@Eikix Eikix deleted the docs/bytecode-storage branch October 2, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @Eikix