Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/compute sn address #418

Merged
merged 20 commits into from
Oct 16, 2023
Merged

Feat/compute sn address #418

merged 20 commits into from
Oct 16, 2023

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Oct 11, 2023 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #397

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@Eikix Eikix requested a review from ClementWalter as a code owner October 11, 2023 10:03
Eikix
Eikix commented Oct 11, 2023
View reviewed changes
Copy link
Member Author

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test this, I'd need to be able to deploy EOAs first with Kakarot

enitrat
enitrat reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/evm/src/kakarot_core.cairo Outdated Show resolved Hide resolved
crates/evm/src/kakarot_core.cairo Outdated Show resolved Hide resolved
crates/utils/src/traits.cairo Outdated Show resolved Hide resolved
crates/utils/src/traits.cairo Outdated Show resolved Hide resolved
crates/utils/src/traits.cairo Outdated Show resolved Hide resolved
Eikix and others added 5 commits October 12, 2023 16:19
@Eikix @enitrat
Update crates/utils/src/traits.cairo
c163863 
Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
@Eikix @enitrat
Update crates/utils/src/traits.cairo
7098b24 
Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
@Eikix @enitrat
Update crates/utils/src/traits.cairo
de17b74 
Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
@Eikix @enitrat
Update crates/evm/src/kakarot_core.cairo
c69a8f2 
Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
@Eikix @enitrat
Update crates/evm/src/kakarot_core.cairo
8fa823e 
Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
@Eikix
Copy link
Member Author

Eikix commented Oct 12, 2023

Thanks for the review siirrrr 🥛🥛🍼🧋

I need a bit more time to write tests for it!

@enitrat
Copy link
Contributor

enitrat commented Oct 12, 2023

bigger tests 🏋️

enitrat
enitrat previously approved these changes Oct 13, 2023
View reviewed changes
enitrat
enitrat reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@enitrat enitrat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove prints

Eikix and others added 2 commits October 13, 2023 19:55
@Eikix @enitrat
Update crates/core_contracts/src/tests/test_kakarot_core.cairo
99ce4e3 
Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
@Eikix
fix: fix comments
52110f6
@Eikix Eikix requested a review from enitrat October 16, 2023 02:22
enitrat
enitrat approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/core_contracts/src/kakarot_core.cairo Show resolved Hide resolved
@enitrat enitrat added this pull request to the merge queue Oct 16, 2023
Merged via the queue into kkrt-labs:main with commit e72a8fd Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: implement EVM Addresses <=> Starknet address mapping for EOAs
2 participants
@Eikix @enitrat