Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increment pc post-opcode execution #955

Merged
merged 6 commits into from
Sep 18, 2024
Merged

fix: increment pc post-opcode execution #955

merged 6 commits into from
Sep 18, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 17, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

  • Fixes an issue where PC should be incremented AFTER opcode execution, not before
  • (skip increment for JUMP family opcodes)

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat requested a review from obatirou September 17, 2024 19:45
@enitrat enitrat requested a review from obatirou September 18, 2024 08:53
@enitrat enitrat added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 058ac2d Sep 18, 2024
4 checks passed
@enitrat enitrat deleted the fix/pc-increment branch September 18, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obatirou obatirou obatirou approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @obatirou