Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizes conversion of bytes to words #985

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Optimizes conversion of bytes to words #985

merged 2 commits into from
Sep 30, 2024

Conversation

lordshashank
Copy link
Contributor

@lordshashank lordshashank commented Sep 27, 2024 •
edited by enitrat
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #940

What is the new behavior?

  • Introduces new function bytes_32_words_size which return number of 32 byte words required to represent size
  • Replaces the ceil32 function with bytes_32_word_size wherever applicable.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

enitrat
enitrat reviewed Sep 27, 2024
View reviewed changes
crates/evm/src/create_helpers.cairo Outdated Show resolved Hide resolved
crates/utils/src/helpers.cairo Outdated Show resolved Hide resolved
crates/evm/src/instructions/environmental_information.cairo Outdated Show resolved Hide resolved
@lordshashank lordshashank force-pushed the optimize-bytes-to-words branch from fe0a8a1 to 4507f2e Compare September 27, 2024 10:59
@lordshashank lordshashank force-pushed the optimize-bytes-to-words branch from 5cd4135 to 274d090 Compare September 27, 2024 15:40
@enitrat enitrat added this pull request to the merge queue Sep 30, 2024
Merged via the queue into kkrt-labs:main with commit 7c289ed Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: optimize conversion of bytes to words
2 participants
@lordshashank @enitrat