Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Commit

Permalink
Fix devcontainer (#1098)
Browse files Browse the repository at this point in the history
Fix devcontainer file
Add new builtin in the python test runner (no impact so far, but to have
the list complete)

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1098)
<!-- Reviewable:end -->
  • Loading branch information
ClementWalter authored Apr 12, 2024
1 parent c4604c7 commit bdde916
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
14 changes: 4 additions & 10 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
{
"name": "Python 3",
"image": "mcr.microsoft.com/vscode/devcontainers/python:0-3.9",
"image": "mcr.microsoft.com/vscode/devcontainers/python:0-3.10",
// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/usr/local/bin/python",
"python.linting.enabled": true,
"python.linting.pylintEnabled": true,
"python.formatting.autopep8Path": "/usr/local/py-utils/bin/autopep8",
"python.formatting.blackPath": "/usr/local/py-utils/bin/black",
"python.formatting.yapfPath": "/usr/local/py-utils/bin/yapf",
"python.linting.banditPath": "/usr/local/py-utils/bin/bandit",
"python.linting.flake8Path": "/usr/local/py-utils/bin/flake8",
"python.linting.mypyPath": "/usr/local/py-utils/bin/mypy",
"python.linting.pycodestylePath": "/usr/local/py-utils/bin/pycodestyle",
"python.linting.pydocstylePath": "/usr/local/py-utils/bin/pydocstyle",
"python.linting.pylintPath": "/usr/local/py-utils/bin/pylint",
"editor.defaultFormatter": "trunk.io",
"cairols.sourceDir": "src",
"cairols.cairoPath": ["src", "tests"]
},
Expand All @@ -27,7 +20,8 @@
"ms-python.python",
"ms-python.vscode-pylance",
"starkware.cairo",
"ericglau.cairo-ls"
"ericglau.cairo-ls",
"trunk.io"
]
}
},
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/starknet.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ def _factory(entrypoint, **kwargs) -> list:
"ec_op",
"keccak",
"poseidon",
"range_check96",
]
if builtin in {arg.replace("_ptr", "") for arg in implicit_args}
]
Expand Down

0 comments on commit bdde916

Please sign in to comment.