Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

dev: initialize_chain_id in deployment scripts if uninitialized #1629

Closed
enitrat opened this issue Nov 21, 2024 · 2 comments · Fixed by #1631
Closed

dev: initialize_chain_id in deployment scripts if uninitialized #1629

enitrat opened this issue Nov 21, 2024 · 2 comments · Fixed by #1631

Comments

@enitrat
Copy link
Collaborator

enitrat commented Nov 21, 2024

Following #1571 we need to add a try block in the deployment script where we call initialize_chain_id, so that existing deployment's chain_id can be updated

@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Nov 21, 2024
@enitrat enitrat changed the title dev: dev: initialize_chain_id in deployment scripts if uninitialized Nov 21, 2024
@SoarinSkySagar
Copy link

SoarinSkySagar commented Nov 21, 2024

May I work on this issue @enitrat?

My approach: I'd go through the PR you mentioned to see the changes made there, and then add the logic to update existing deployment's chain_id by adding a try block containing the initialize_chain_id function, which would be called if the script is uninitialized, in the appropriate place.

ETA: 3 days

@enitrat
Copy link
Collaborator Author

enitrat commented Nov 21, 2024

hey, yeah that'd be the right approach, inside kakarot_deployment.py but I need it in the next hour sorry

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: ✅ Done
2 participants