This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
feat: chain_id storage var #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obatirou
force-pushed
the
chain-id-storage-var
branch
2 times, most recently
from
cda8f4f to
87d44ca
Compare
|
Waiting on ef tests change to take into account chain id var |
9 tasks
ClementWalter
previously approved these changes
Nov 5, 2024
obatirou
force-pushed
the
chain-id-storage-var
branch
from
87d44ca to
95c191b
Compare
enitrat
reviewed
Nov 5, 2024
obatirou
force-pushed
the
chain-id-storage-var
branch
from
95c191b to
81a9e6c
Compare
I do not think this is necessary for the setter: once a chain_id is set this should not change Maybe a getter indeed |
The getter is already here with eth_chain_id |
ClementWalter
approved these changes
Nov 6, 2024
enitrat
approved these changes
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1530
What is the new behavior?
Chain id is set in constructor and stored in storage
This change is