-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: opcode 0x08 SIGNEXTEND not conform to spec #677
Milestone
Comments
ClementWalter
pushed a commit
that referenced
this issue
Nov 16, 2023
<!--- Please provide a general summary of your changes in the title above --> <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: 0.5d ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Resolves #677
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Kakarot on Starknet
Nov 16, 2023
Eikix
added a commit
to Eikix/kakarot
that referenced
this issue
Nov 16, 2023
<!--- Please provide a general summary of your changes in the title above --> <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: 0.5d <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Resolves kkrt-labs#677
Eikix
added a commit
to Eikix/kakarot
that referenced
this issue
Nov 16, 2023
<!--- Please provide a general summary of your changes in the title above --> <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: 0.5d <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Resolves kkrt-labs#677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Kakarot version:
last version
Current behavior:
The current implementation is
https://github.com/kkrt-labs/kakarot/blob/main/src/kakarot/instructions/stop_and_arithmetic_operations.cairo#L414-L443
Expected behavior:
The expected behavior is the one explained in the whitepaper, further explained in this post https://ethereum.stackexchange.com/questions/63062/evm-signextend-opcode-explanation
For example, executing the following opcodes
Should result in 0xffff....ffff (u256_max -1)
Steps to reproduce:
Related code:
Other information:
The text was updated successfully, but these errors were encountered: