New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store jumpdests #1130

Merged

enitrat merged 18 commits into main from feat/store-jumpdests

May 14, 2024

Collaborator

enitrat commented Apr 29, 2024 •

edited

Loading

Time spent on this PR:

Benchmark: using test_should_add_liquidity (a test that switches back-and-fourth between multiple contracts multiple times and thus should benefit from the caching mechanism)

Before

TRACE executor: Transaction resource usage. usage="Steps: 8093994 | Bitwise: 1420 | Keccak: 115 | L1 Gas: 364303 | Pedersen: 621 | Range Checks: 391939"

After

Transaction resource usage. usage="Steps: 6344085 | Bitwise: 1420 | Keccak: 115 | L1 Gas: 653027 | Pedersen: 1503 | Range Checks: 308089"

=> 1.7M steps saved

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Resolves #

What is the new behavior?

This change is

enitrat force-pushed the feat/store-jumpdests branch 2 times, most recently from 36b432b to 69d8511 Compare

April 30, 2024 14:19

enitrat marked this pull request as ready for review

April 30, 2024 14:25

ClementWalter reviewed

View reviewed changes

src/kakarot/account.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/account.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/interfaces/interfaces.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/evm.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/interpreter.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/end_to_end/test_kakarot.py Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/end_to_end/test_kakarot.py Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/src/backend/test_starknet.py Outdated Show resolved Hide resolved

enitrat force-pushed the feat/store-jumpdests branch from 2a0222a to 836b7f3 Compare

May 2, 2024 09:18

ClementWalter reviewed

View reviewed changes

src/backend/starknet.cairo Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/accounts/library.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/accounts/library.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/accounts/library.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/account.cairo Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/evm.cairo Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/interpreter.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/src/backend/test_starknet.py Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/src/kakarot/accounts/test_contract_account.py Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/src/kakarot/accounts/test_contract_account.py Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/src/kakarot/accounts/test_contract_account.py Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/src/kakarot/accounts/test_contract_account.py Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

tests/utils/helpers.cairo Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/backend/starknet.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/backend/starknet.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/backend/starknet.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/accounts/library.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/accounts/library.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/account.cairo Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/backend/starknet.cairo Outdated Show resolved Hide resolved

ClementWalter reviewed

View reviewed changes

src/kakarot/account.cairo Outdated Show resolved Hide resolved

enitrat added 17 commits

May 14, 2024 11:43


          feat: store jumpdests in account

c5a0775


          feat: jumpdests cache

e62a9a7


          jumpdest cache mechanism

91aff9a


          fix: create caches account code instead of initcode

0b804fc


          save jumpdests on new contracts

8f7964a


          adapt tests setup

04260fd


          fix: cached jumpdests bug

5f8c811


          fix range_check_builtin missing pointer issue

596a38e


          fix end-to-end test requiring account deployment

646e758


          wait for account deploy tx

99ba4fb


          address pr review

36d0ff2


          point CI to updated ef-tests

1279d59


          address pr review

7d5c449


          address review

57f53ce


          improve find_selector script

ac82b4d


          fix comment

a09f5a5


          address review

7bd2f02

enitrat force-pushed the feat/store-jumpdests branch from 8938a00 to 7bd2f02 Compare

May 14, 2024 09:44

ClementWalter previously approved these changes

View reviewed changes


          fix set code

dade065

enitrat dismissed ClementWalter’s stale review via

dade065

May 14, 2024 10:41

enitrat force-pushed the feat/store-jumpdests branch from c11f9fb to dade065 Compare

May 14, 2024 10:41

ClementWalter approved these changes

View reviewed changes

enitrat merged commit e34b0de into main

7 checks passed

enitrat deleted the feat/store-jumpdests branch

May 14, 2024 12:23

ClementWalter mentioned this pull request

Use web3 with Kakarot RPC in end-to-end tests when available #1164

Merged

matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request


          feat: add solidity error decoding (kkrt-labs#1130)

85b3520

add solidity error decoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet